Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide additional String formating utility method to reduce code duplication #3310

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Provide additional String formating utility method to reduce code duplication #3310

merged 4 commits into from
Oct 23, 2023

Conversation

unp1
Copy link
Member

@unp1 unp1 commented Oct 20, 2023 •
edited
Loading

Some minor cleanup with the side effect of providing a test suite for class Strings in key.util

@unp1 unp1 self-assigned this Oct 20, 2023
@unp1 unp1 added 🛠 Maintenance Code quality and related things w/o functional changes Ignore in Changelog If given, a PR will not be considered for Changelog generation. Use this on unimportant stuff. labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #3310 (4b131f4) into main (671da01) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##               main    #3310      +/-   ##
============================================
- Coverage     37.81%   37.81%   -0.01%     
  Complexity    16856    16856              
============================================
  Files          2051     2051              
  Lines        125422   125351      -71     
  Branches      21226    21201      -25     
============================================
- Hits          47433    47398      -35     
+ Misses        72150    72114      -36     
  Partials       5839     5839
Files Coverage Δ
.../src/main/java/de/uka/ilkd/key/logic/TermImpl.java 84.04% <100.00%> (-0.60%) ⬇️
...ore/src/main/java/de/uka/ilkd/key/rule/Taclet.java 76.11% <100.00%> (-1.89%) ⬇️
...il/src/main/java/org/key_project/util/Strings.java 75.00% <100.00%> (+75.00%) ⬆️
...y_project/util/collection/DefaultImmutableSet.java 58.18% <100.00%> (-2.51%) ⬇️
...g/key_project/util/collection/ImmutableSLList.java 63.44% <100.00%> (-1.33%) ⬇️
...c/main/java/de/uka/ilkd/key/logic/op/Function.java 68.29% <0.00%> (+9.95%) ⬆️
...y_project/util/collection/DefaultImmutableMap.java 51.00% <0.00%> (+2.28%) ⬆️
...rg/key_project/util/collection/ImmutableArray.java 0.00% <0.00%> (ø)
..._project/util/collection/ImmutableLeftistHeap.java 81.90% <0.00%> (+5.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

@unp1 unp1 force-pushed the reduceCodeDup branch 7 times, most recently from 96ad44f to 3f4ebee Compare October 20, 2023 18:54
@unp1 unp1 assigned unp1 and unassigned unp1 Oct 20, 2023
@unp1 unp1 enabled auto-merge October 22, 2023 20:43
@unp1 unp1 added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 65639e6 Oct 23, 2023
13 of 14 checks passed
@unp1 unp1 deleted the reduceCodeDup branch October 23, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadoon wadoon wadoon approved these changes

Assignees

@unp1 unp1

Labels
Ignore in Changelog If given, a PR will not be considered for Changelog generation. Use this on unimportant stuff. 🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unp1 @wadoon